fix(build): 💊 make Android build script cross platform #1684
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1684 +/- ##
======================================
Coverage 36% 36%
======================================
Files 45 45
Lines 2749 2749
Branches 312 312
======================================
Hits 1006 1006
Misses 1743 1743
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@daniellacosse BTW, what should I do to deal with these code coverage errors? |
|
|
||
| module.exports = function(context) { | ||
| const ANDROID_LIBS_FOLDER_PATH = 'plugins/cordova-plugin-outline/android/libs'; |
There was a problem hiding this comment.
I've been separating these kinds of paths into arrays but if it works for you I don't see why we need to do that (re: @fortuna)
There was a problem hiding this comment.
ah yes, this can make the path more cross-platform. updated.
Ignore for now, we should either turn it off or spend some time figuring out why it's started breaking |
This PR fixes #1670 .